ghsa-c425-5ghg-6j48
Vulnerability from github
Published
2024-05-22 09:31
Modified
2024-05-22 09:31
Details

In the Linux kernel, the following vulnerability has been resolved:

net/tls: Fix flipped sign in tls_err_abort() calls

sk->sk_err appears to expect a positive value, a convention that ktls doesn't always follow and that leads to memory corruption in other code. For instance,

[kworker]
tls_encrypt_done(..., err=<negative error from crypto request>)
  tls_err_abort(.., err)
    sk->sk_err = err;

[task]
splice_from_pipe_feed
  ...
    tls_sw_do_sendpage
      if (sk->sk_err) {
        ret = -sk->sk_err;  // ret is positive

splice_from_pipe_feed (continued)
  ret = actor(...)  // ret is still positive and interpreted as bytes
                    // written, resulting in underflow of buf->len and
                    // sd->len, leading to huge buf->offset and bogus
                    // addresses computed in later calls to actor()

Fix all tls_err_abort() callers to pass a negative error code consistently and centralize the error-prone sign flip there, throwing in a warning to catch future misuse and uninlining the function so it really does only warn once.

Show details on source website

To clipboard 

{
   affected: [],
   aliases: [
      "CVE-2021-47496",
   ],
   database_specific: {
      cwe_ids: [],
      github_reviewed: false,
      github_reviewed_at: null,
      nvd_published_at: "2024-05-22T09:15:11Z",
      severity: null,
   },
   details: "In the Linux kernel, the following vulnerability has been resolved:\n\nnet/tls: Fix flipped sign in tls_err_abort() calls\n\nsk->sk_err appears to expect a positive value, a convention that ktls\ndoesn't always follow and that leads to memory corruption in other code.\nFor instance,\n\n    [kworker]\n    tls_encrypt_done(..., err=<negative error from crypto request>)\n      tls_err_abort(.., err)\n        sk->sk_err = err;\n\n    [task]\n    splice_from_pipe_feed\n      ...\n        tls_sw_do_sendpage\n          if (sk->sk_err) {\n            ret = -sk->sk_err;  // ret is positive\n\n    splice_from_pipe_feed (continued)\n      ret = actor(...)  // ret is still positive and interpreted as bytes\n                        // written, resulting in underflow of buf->len and\n                        // sd->len, leading to huge buf->offset and bogus\n                        // addresses computed in later calls to actor()\n\nFix all tls_err_abort() callers to pass a negative error code\nconsistently and centralize the error-prone sign flip there, throwing in\na warning to catch future misuse and uninlining the function so it\nreally does only warn once.",
   id: "GHSA-c425-5ghg-6j48",
   modified: "2024-05-22T09:31:47Z",
   published: "2024-05-22T09:31:46Z",
   references: [
      {
         type: "ADVISORY",
         url: "https://nvd.nist.gov/vuln/detail/CVE-2021-47496",
      },
      {
         type: "WEB",
         url: "https://git.kernel.org/stable/c/da353fac65fede6b8b4cfe207f0d9408e3121105",
      },
      {
         type: "WEB",
         url: "https://git.kernel.org/stable/c/e0cfd5159f314d6b304d030363650b06a2299cbb",
      },
      {
         type: "WEB",
         url: "https://git.kernel.org/stable/c/e41473543f75f7dbc5d605007e6f883f1bd13b9a",
      },
      {
         type: "WEB",
         url: "https://git.kernel.org/stable/c/f3dec7e7ace38224f82cf83f0049159d067c2e19",
      },
   ],
   schema_version: "1.4.0",
   severity: [],
}


Log in or create an account to share your comment.

Security Advisory comment format.

This schema specifies the format of a comment related to a security advisory.

UUIDv4 of the comment
UUIDv4 of the Vulnerability-Lookup instance
When the comment was created originally
When the comment was last updated
Title of the comment
Description of the comment
The identifier of the vulnerability (CVE ID, GHSA-ID, PYSEC ID, etc.).



Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
  • Confirmed: The vulnerability is confirmed from an analyst perspective.
  • Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
  • Patched: This vulnerability was successfully patched by the user reporting the sighting.
  • Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
  • Not confirmed: The user expresses doubt about the veracity of the vulnerability.
  • Not patched: This vulnerability was not successfully patched by the user reporting the sighting.