cve-2024-56555
Vulnerability from cvelistv5
Published
2024-12-27 14:23
Modified
2025-01-20 06:22
Severity ?
Summary
In the Linux kernel, the following vulnerability has been resolved: binder: fix OOB in binder_add_freeze_work() In binder_add_freeze_work() we iterate over the proc->nodes with the proc->inner_lock held. However, this lock is temporarily dropped to acquire the node->lock first (lock nesting order). This can race with binder_deferred_release() which removes the nodes from the proc->nodes rbtree and adds them into binder_dead_nodes list. This leads to a broken iteration in binder_add_freeze_work() as rb_next() will use data from binder_dead_nodes, triggering an out-of-bounds access: ================================================================== BUG: KASAN: global-out-of-bounds in rb_next+0xfc/0x124 Read of size 8 at addr ffffcb84285f7170 by task freeze/660 CPU: 8 UID: 0 PID: 660 Comm: freeze Not tainted 6.11.0-07343-ga727812a8d45 #18 Hardware name: linux,dummy-virt (DT) Call trace: rb_next+0xfc/0x124 binder_add_freeze_work+0x344/0x534 binder_ioctl+0x1e70/0x25ac __arm64_sys_ioctl+0x124/0x190 The buggy address belongs to the variable: binder_dead_nodes+0x10/0x40 [...] ================================================================== This is possible because proc->nodes (rbtree) and binder_dead_nodes (list) share entries in binder_node through a union: struct binder_node { [...] union { struct rb_node rb_node; struct hlist_node dead_node; }; Fix the race by checking that the proc is still alive. If not, simply break out of the iteration.
References
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/011e69a1b23011c0db3af4b8293fdd4522cc97b0
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/6b1be1da1f8279cf091266e71b5153c5b02aaff6
Impacted products
Vendor Product Version
Linux Linux Version: d579b04a52a183db47dfcb7a44304d7747d551e1
Version: d579b04a52a183db47dfcb7a44304d7747d551e1
 Create a notification for this product.
   Linux Linux Version: 6.12
 Create a notification for this product.
Show details on NVD website

To clipboard 

{
  "containers": {
    "cna": {
      "affected": [
        {
          "defaultStatus": "unaffected",
          "product": "Linux",
          "programFiles": [
            "drivers/android/binder.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "lessThan": "6b1be1da1f8279cf091266e71b5153c5b02aaff6",
              "status": "affected",
              "version": "d579b04a52a183db47dfcb7a44304d7747d551e1",
              "versionType": "git"
            },
            {
              "lessThan": "011e69a1b23011c0db3af4b8293fdd4522cc97b0",
              "status": "affected",
              "version": "d579b04a52a183db47dfcb7a44304d7747d551e1",
              "versionType": "git"
            }
          ]
        },
        {
          "defaultStatus": "affected",
          "product": "Linux",
          "programFiles": [
            "drivers/android/binder.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "status": "affected",
              "version": "6.12"
            },
            {
              "lessThan": "6.12",
              "status": "unaffected",
              "version": "0",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "6.12.*",
              "status": "unaffected",
              "version": "6.12.4",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "*",
              "status": "unaffected",
              "version": "6.13",
              "versionType": "original_commit_for_fix"
            }
          ]
        }
      ],
      "descriptions": [
        {
          "lang": "en",
          "value": "In the Linux kernel, the following vulnerability has been resolved:\n\nbinder: fix OOB in binder_add_freeze_work()\n\nIn binder_add_freeze_work() we iterate over the proc-\u003enodes with the\nproc-\u003einner_lock held. However, this lock is temporarily dropped to\nacquire the node-\u003elock first (lock nesting order). This can race with\nbinder_deferred_release() which removes the nodes from the proc-\u003enodes\nrbtree and adds them into binder_dead_nodes list. This leads to a broken\niteration in binder_add_freeze_work() as rb_next() will use data from\nbinder_dead_nodes, triggering an out-of-bounds access:\n\n  ==================================================================\n  BUG: KASAN: global-out-of-bounds in rb_next+0xfc/0x124\n  Read of size 8 at addr ffffcb84285f7170 by task freeze/660\n\n  CPU: 8 UID: 0 PID: 660 Comm: freeze Not tainted 6.11.0-07343-ga727812a8d45 #18\n  Hardware name: linux,dummy-virt (DT)\n  Call trace:\n   rb_next+0xfc/0x124\n   binder_add_freeze_work+0x344/0x534\n   binder_ioctl+0x1e70/0x25ac\n   __arm64_sys_ioctl+0x124/0x190\n\n  The buggy address belongs to the variable:\n   binder_dead_nodes+0x10/0x40\n  [...]\n  ==================================================================\n\nThis is possible because proc-\u003enodes (rbtree) and binder_dead_nodes\n(list) share entries in binder_node through a union:\n\n\tstruct binder_node {\n\t[...]\n\t\tunion {\n\t\t\tstruct rb_node rb_node;\n\t\t\tstruct hlist_node dead_node;\n\t\t};\n\nFix the race by checking that the proc is still alive. If not, simply\nbreak out of the iteration."
        }
      ],
      "providerMetadata": {
        "dateUpdated": "2025-01-20T06:22:54.361Z",
        "orgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
        "shortName": "Linux"
      },
      "references": [
        {
          "url": "https://git.kernel.org/stable/c/6b1be1da1f8279cf091266e71b5153c5b02aaff6"
        },
        {
          "url": "https://git.kernel.org/stable/c/011e69a1b23011c0db3af4b8293fdd4522cc97b0"
        }
      ],
      "title": "binder: fix OOB in binder_add_freeze_work()",
      "x_generator": {
        "engine": "bippy-5f407fcff5a0"
      }
    }
  },
  "cveMetadata": {
    "assignerOrgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
    "assignerShortName": "Linux",
    "cveId": "CVE-2024-56555",
    "datePublished": "2024-12-27T14:23:01.650Z",
    "dateReserved": "2024-12-27T14:03:05.990Z",
    "dateUpdated": "2025-01-20T06:22:54.361Z",
    "state": "PUBLISHED"
  },
  "dataType": "CVE_RECORD",
  "dataVersion": "5.1",
  "vulnerability-lookup:meta": {
    "nvd": "{\"cve\":{\"id\":\"CVE-2024-56555\",\"sourceIdentifier\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\",\"published\":\"2024-12-27T15:15:14.297\",\"lastModified\":\"2024-12-27T15:15:14.297\",\"vulnStatus\":\"Received\",\"cveTags\":[],\"descriptions\":[{\"lang\":\"en\",\"value\":\"In the Linux kernel, the following vulnerability has been resolved:\\n\\nbinder: fix OOB in binder_add_freeze_work()\\n\\nIn binder_add_freeze_work() we iterate over the proc-\u003enodes with the\\nproc-\u003einner_lock held. However, this lock is temporarily dropped to\\nacquire the node-\u003elock first (lock nesting order). This can race with\\nbinder_deferred_release() which removes the nodes from the proc-\u003enodes\\nrbtree and adds them into binder_dead_nodes list. This leads to a broken\\niteration in binder_add_freeze_work() as rb_next() will use data from\\nbinder_dead_nodes, triggering an out-of-bounds access:\\n\\n  ==================================================================\\n  BUG: KASAN: global-out-of-bounds in rb_next+0xfc/0x124\\n  Read of size 8 at addr ffffcb84285f7170 by task freeze/660\\n\\n  CPU: 8 UID: 0 PID: 660 Comm: freeze Not tainted 6.11.0-07343-ga727812a8d45 #18\\n  Hardware name: linux,dummy-virt (DT)\\n  Call trace:\\n   rb_next+0xfc/0x124\\n   binder_add_freeze_work+0x344/0x534\\n   binder_ioctl+0x1e70/0x25ac\\n   __arm64_sys_ioctl+0x124/0x190\\n\\n  The buggy address belongs to the variable:\\n   binder_dead_nodes+0x10/0x40\\n  [...]\\n  ==================================================================\\n\\nThis is possible because proc-\u003enodes (rbtree) and binder_dead_nodes\\n(list) share entries in binder_node through a union:\\n\\n\\tstruct binder_node {\\n\\t[...]\\n\\t\\tunion {\\n\\t\\t\\tstruct rb_node rb_node;\\n\\t\\t\\tstruct hlist_node dead_node;\\n\\t\\t};\\n\\nFix the race by checking that the proc is still alive. If not, simply\\nbreak out of the iteration.\"}],\"metrics\":{},\"references\":[{\"url\":\"https://git.kernel.org/stable/c/011e69a1b23011c0db3af4b8293fdd4522cc97b0\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/6b1be1da1f8279cf091266e71b5153c5b02aaff6\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"}]}}"
  }
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
  • Confirmed: The vulnerability is confirmed from an analyst perspective.
  • Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
  • Patched: This vulnerability was successfully patched by the user reporting the sighting.
  • Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
  • Not confirmed: The user expresses doubt about the veracity of the vulnerability.
  • Not patched: This vulnerability was not successfully patched by the user reporting the sighting.