cve-2024-53219
Vulnerability from cvelistv5
Published
2024-12-27 13:50
Modified
2025-01-20 06:21
Severity ?
Summary
In the Linux kernel, the following vulnerability has been resolved: virtiofs: use pages instead of pointer for kernel direct IO When trying to insert a 10MB kernel module kept in a virtio-fs with cache disabled, the following warning was reported: ------------[ cut here ]------------ WARNING: CPU: 1 PID: 404 at mm/page_alloc.c:4551 ...... Modules linked in: CPU: 1 PID: 404 Comm: insmod Not tainted 6.9.0-rc5+ #123 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996) ...... RIP: 0010:__alloc_pages+0x2bf/0x380 ...... Call Trace: <TASK> ? __warn+0x8e/0x150 ? __alloc_pages+0x2bf/0x380 __kmalloc_large_node+0x86/0x160 __kmalloc+0x33c/0x480 virtio_fs_enqueue_req+0x240/0x6d0 virtio_fs_wake_pending_and_unlock+0x7f/0x190 queue_request_and_unlock+0x55/0x60 fuse_simple_request+0x152/0x2b0 fuse_direct_io+0x5d2/0x8c0 fuse_file_read_iter+0x121/0x160 __kernel_read+0x151/0x2d0 kernel_read+0x45/0x50 kernel_read_file+0x1a9/0x2a0 init_module_from_file+0x6a/0xe0 idempotent_init_module+0x175/0x230 __x64_sys_finit_module+0x5d/0xb0 x64_sys_call+0x1c3/0x9e0 do_syscall_64+0x3d/0xc0 entry_SYSCALL_64_after_hwframe+0x4b/0x53 ...... </TASK> ---[ end trace 0000000000000000 ]--- The warning is triggered as follows: 1) syscall finit_module() handles the module insertion and it invokes kernel_read_file() to read the content of the module first. 2) kernel_read_file() allocates a 10MB buffer by using vmalloc() and passes it to kernel_read(). kernel_read() constructs a kvec iter by using iov_iter_kvec() and passes it to fuse_file_read_iter(). 3) virtio-fs disables the cache, so fuse_file_read_iter() invokes fuse_direct_io(). As for now, the maximal read size for kvec iter is only limited by fc->max_read. For virtio-fs, max_read is UINT_MAX, so fuse_direct_io() doesn't split the 10MB buffer. It saves the address and the size of the 10MB-sized buffer in out_args[0] of a fuse request and passes the fuse request to virtio_fs_wake_pending_and_unlock(). 4) virtio_fs_wake_pending_and_unlock() uses virtio_fs_enqueue_req() to queue the request. Because virtiofs need DMA-able address, so virtio_fs_enqueue_req() uses kmalloc() to allocate a bounce buffer for all fuse args, copies these args into the bounce buffer and passed the physical address of the bounce buffer to virtiofsd. The total length of these fuse args for the passed fuse request is about 10MB, so copy_args_to_argbuf() invokes kmalloc() with a 10MB size parameter and it triggers the warning in __alloc_pages(): if (WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp)) return NULL; 5) virtio_fs_enqueue_req() will retry the memory allocation in a kworker, but it won't help, because kmalloc() will always return NULL due to the abnormal size and finit_module() will hang forever. A feasible solution is to limit the value of max_read for virtio-fs, so the length passed to kmalloc() will be limited. However it will affect the maximal read size for normal read. And for virtio-fs write initiated from kernel, it has the similar problem but now there is no way to limit fc->max_write in kernel. So instead of limiting both the values of max_read and max_write in kernel, introducing use_pages_for_kvec_io in fuse_conn and setting it as true in virtiofs. When use_pages_for_kvec_io is enabled, fuse will use pages instead of pointer to pass the KVEC_IO data. After switching to pages for KVEC_IO data, these pages will be used for DMA through virtio-fs. If these pages are backed by vmalloc(), {flush|invalidate}_kernel_vmap_range() are necessary to flush or invalidate the cache before the DMA operation. So add two new fields in fuse_args_pages to record the base address of vmalloc area and the condition indicating whether invalidation is needed. Perform the flush in fuse_get_user_pages() for write operations and the invalidation in fuse_release_user_pages() for read operations. It may seem necessary to introduce another fie ---truncated---
References
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/2bc07714dc955a91d2923a440ea02c3cb3376b10
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/41748675c0bf252b3c5f600a95830f0936d366c1
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/9a8fde56d4b6d51930936ed50f6370a9097328d1
Impacted products
Vendor Product Version
Linux Linux Version: a62a8ef9d97da23762a588592c8b8eb50a8deb6a
Version: a62a8ef9d97da23762a588592c8b8eb50a8deb6a
Version: a62a8ef9d97da23762a588592c8b8eb50a8deb6a
 Create a notification for this product.
   Linux Linux Version: 5.4
 Create a notification for this product.
Show details on NVD website

To clipboard 

{
   containers: {
      cna: {
         affected: [
            {
               defaultStatus: "unaffected",
               product: "Linux",
               programFiles: [
                  "fs/fuse/file.c",
                  "fs/fuse/fuse_i.h",
                  "fs/fuse/virtio_fs.c",
               ],
               repo: "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
               vendor: "Linux",
               versions: [
                  {
                     lessThan: "9a8fde56d4b6d51930936ed50f6370a9097328d1",
                     status: "affected",
                     version: "a62a8ef9d97da23762a588592c8b8eb50a8deb6a",
                     versionType: "git",
                  },
                  {
                     lessThan: "2bc07714dc955a91d2923a440ea02c3cb3376b10",
                     status: "affected",
                     version: "a62a8ef9d97da23762a588592c8b8eb50a8deb6a",
                     versionType: "git",
                  },
                  {
                     lessThan: "41748675c0bf252b3c5f600a95830f0936d366c1",
                     status: "affected",
                     version: "a62a8ef9d97da23762a588592c8b8eb50a8deb6a",
                     versionType: "git",
                  },
               ],
            },
            {
               defaultStatus: "affected",
               product: "Linux",
               programFiles: [
                  "fs/fuse/file.c",
                  "fs/fuse/fuse_i.h",
                  "fs/fuse/virtio_fs.c",
               ],
               repo: "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
               vendor: "Linux",
               versions: [
                  {
                     status: "affected",
                     version: "5.4",
                  },
                  {
                     lessThan: "5.4",
                     status: "unaffected",
                     version: "0",
                     versionType: "semver",
                  },
                  {
                     lessThanOrEqual: "6.11.*",
                     status: "unaffected",
                     version: "6.11.11",
                     versionType: "semver",
                  },
                  {
                     lessThanOrEqual: "6.12.*",
                     status: "unaffected",
                     version: "6.12.2",
                     versionType: "semver",
                  },
                  {
                     lessThanOrEqual: "*",
                     status: "unaffected",
                     version: "6.13",
                     versionType: "original_commit_for_fix",
                  },
               ],
            },
         ],
         descriptions: [
            {
               lang: "en",
               value: "In the Linux kernel, the following vulnerability has been resolved:\n\nvirtiofs: use pages instead of pointer for kernel direct IO\n\nWhen trying to insert a 10MB kernel module kept in a virtio-fs with cache\ndisabled, the following warning was reported:\n\n  ------------[ cut here ]------------\n  WARNING: CPU: 1 PID: 404 at mm/page_alloc.c:4551 ......\n  Modules linked in:\n  CPU: 1 PID: 404 Comm: insmod Not tainted 6.9.0-rc5+ #123\n  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996) ......\n  RIP: 0010:__alloc_pages+0x2bf/0x380\n  ......\n  Call Trace:\n   <TASK>\n   ? __warn+0x8e/0x150\n   ? __alloc_pages+0x2bf/0x380\n   __kmalloc_large_node+0x86/0x160\n   __kmalloc+0x33c/0x480\n   virtio_fs_enqueue_req+0x240/0x6d0\n   virtio_fs_wake_pending_and_unlock+0x7f/0x190\n   queue_request_and_unlock+0x55/0x60\n   fuse_simple_request+0x152/0x2b0\n   fuse_direct_io+0x5d2/0x8c0\n   fuse_file_read_iter+0x121/0x160\n   __kernel_read+0x151/0x2d0\n   kernel_read+0x45/0x50\n   kernel_read_file+0x1a9/0x2a0\n   init_module_from_file+0x6a/0xe0\n   idempotent_init_module+0x175/0x230\n   __x64_sys_finit_module+0x5d/0xb0\n   x64_sys_call+0x1c3/0x9e0\n   do_syscall_64+0x3d/0xc0\n   entry_SYSCALL_64_after_hwframe+0x4b/0x53\n   ......\n   </TASK>\n  ---[ end trace 0000000000000000 ]---\n\nThe warning is triggered as follows:\n\n1) syscall finit_module() handles the module insertion and it invokes\nkernel_read_file() to read the content of the module first.\n\n2) kernel_read_file() allocates a 10MB buffer by using vmalloc() and\npasses it to kernel_read(). kernel_read() constructs a kvec iter by\nusing iov_iter_kvec() and passes it to fuse_file_read_iter().\n\n3) virtio-fs disables the cache, so fuse_file_read_iter() invokes\nfuse_direct_io(). As for now, the maximal read size for kvec iter is\nonly limited by fc->max_read. For virtio-fs, max_read is UINT_MAX, so\nfuse_direct_io() doesn't split the 10MB buffer. It saves the address and\nthe size of the 10MB-sized buffer in out_args[0] of a fuse request and\npasses the fuse request to virtio_fs_wake_pending_and_unlock().\n\n4) virtio_fs_wake_pending_and_unlock() uses virtio_fs_enqueue_req() to\nqueue the request. Because virtiofs need DMA-able address, so\nvirtio_fs_enqueue_req() uses kmalloc() to allocate a bounce buffer for\nall fuse args, copies these args into the bounce buffer and passed the\nphysical address of the bounce buffer to virtiofsd. The total length of\nthese fuse args for the passed fuse request is about 10MB, so\ncopy_args_to_argbuf() invokes kmalloc() with a 10MB size parameter and\nit triggers the warning in __alloc_pages():\n\n\tif (WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp))\n\t\treturn NULL;\n\n5) virtio_fs_enqueue_req() will retry the memory allocation in a\nkworker, but it won't help, because kmalloc() will always return NULL\ndue to the abnormal size and finit_module() will hang forever.\n\nA feasible solution is to limit the value of max_read for virtio-fs, so\nthe length passed to kmalloc() will be limited. However it will affect\nthe maximal read size for normal read. And for virtio-fs write initiated\nfrom kernel, it has the similar problem but now there is no way to limit\nfc->max_write in kernel.\n\nSo instead of limiting both the values of max_read and max_write in\nkernel, introducing use_pages_for_kvec_io in fuse_conn and setting it as\ntrue in virtiofs. When use_pages_for_kvec_io is enabled, fuse will use\npages instead of pointer to pass the KVEC_IO data.\n\nAfter switching to pages for KVEC_IO data, these pages will be used for\nDMA through virtio-fs. If these pages are backed by vmalloc(),\n{flush|invalidate}_kernel_vmap_range() are necessary to flush or\ninvalidate the cache before the DMA operation. So add two new fields in\nfuse_args_pages to record the base address of vmalloc area and the\ncondition indicating whether invalidation is needed. Perform the flush\nin fuse_get_user_pages() for write operations and the invalidation in\nfuse_release_user_pages() for read operations.\n\nIt may seem necessary to introduce another fie\n---truncated---",
            },
         ],
         providerMetadata: {
            dateUpdated: "2025-01-20T06:21:29.104Z",
            orgId: "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
            shortName: "Linux",
         },
         references: [
            {
               url: "https://git.kernel.org/stable/c/9a8fde56d4b6d51930936ed50f6370a9097328d1",
            },
            {
               url: "https://git.kernel.org/stable/c/2bc07714dc955a91d2923a440ea02c3cb3376b10",
            },
            {
               url: "https://git.kernel.org/stable/c/41748675c0bf252b3c5f600a95830f0936d366c1",
            },
         ],
         title: "virtiofs: use pages instead of pointer for kernel direct IO",
         x_generator: {
            engine: "bippy-5f407fcff5a0",
         },
      },
   },
   cveMetadata: {
      assignerOrgId: "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
      assignerShortName: "Linux",
      cveId: "CVE-2024-53219",
      datePublished: "2024-12-27T13:50:04.550Z",
      dateReserved: "2024-11-19T17:17:25.024Z",
      dateUpdated: "2025-01-20T06:21:29.104Z",
      state: "PUBLISHED",
   },
   dataType: "CVE_RECORD",
   dataVersion: "5.1",
   "vulnerability-lookup:meta": {
      nvd: "{\"cve\":{\"id\":\"CVE-2024-53219\",\"sourceIdentifier\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\",\"published\":\"2024-12-27T14:15:29.963\",\"lastModified\":\"2024-12-27T14:15:29.963\",\"vulnStatus\":\"Received\",\"cveTags\":[],\"descriptions\":[{\"lang\":\"en\",\"value\":\"In the Linux kernel, the following vulnerability has been resolved:\\n\\nvirtiofs: use pages instead of pointer for kernel direct IO\\n\\nWhen trying to insert a 10MB kernel module kept in a virtio-fs with cache\\ndisabled, the following warning was reported:\\n\\n  ------------[ cut here ]------------\\n  WARNING: CPU: 1 PID: 404 at mm/page_alloc.c:4551 ......\\n  Modules linked in:\\n  CPU: 1 PID: 404 Comm: insmod Not tainted 6.9.0-rc5+ #123\\n  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996) ......\\n  RIP: 0010:__alloc_pages+0x2bf/0x380\\n  ......\\n  Call Trace:\\n   <TASK>\\n   ? __warn+0x8e/0x150\\n   ? __alloc_pages+0x2bf/0x380\\n   __kmalloc_large_node+0x86/0x160\\n   __kmalloc+0x33c/0x480\\n   virtio_fs_enqueue_req+0x240/0x6d0\\n   virtio_fs_wake_pending_and_unlock+0x7f/0x190\\n   queue_request_and_unlock+0x55/0x60\\n   fuse_simple_request+0x152/0x2b0\\n   fuse_direct_io+0x5d2/0x8c0\\n   fuse_file_read_iter+0x121/0x160\\n   __kernel_read+0x151/0x2d0\\n   kernel_read+0x45/0x50\\n   kernel_read_file+0x1a9/0x2a0\\n   init_module_from_file+0x6a/0xe0\\n   idempotent_init_module+0x175/0x230\\n   __x64_sys_finit_module+0x5d/0xb0\\n   x64_sys_call+0x1c3/0x9e0\\n   do_syscall_64+0x3d/0xc0\\n   entry_SYSCALL_64_after_hwframe+0x4b/0x53\\n   ......\\n   </TASK>\\n  ---[ end trace 0000000000000000 ]---\\n\\nThe warning is triggered as follows:\\n\\n1) syscall finit_module() handles the module insertion and it invokes\\nkernel_read_file() to read the content of the module first.\\n\\n2) kernel_read_file() allocates a 10MB buffer by using vmalloc() and\\npasses it to kernel_read(). kernel_read() constructs a kvec iter by\\nusing iov_iter_kvec() and passes it to fuse_file_read_iter().\\n\\n3) virtio-fs disables the cache, so fuse_file_read_iter() invokes\\nfuse_direct_io(). As for now, the maximal read size for kvec iter is\\nonly limited by fc->max_read. For virtio-fs, max_read is UINT_MAX, so\\nfuse_direct_io() doesn't split the 10MB buffer. It saves the address and\\nthe size of the 10MB-sized buffer in out_args[0] of a fuse request and\\npasses the fuse request to virtio_fs_wake_pending_and_unlock().\\n\\n4) virtio_fs_wake_pending_and_unlock() uses virtio_fs_enqueue_req() to\\nqueue the request. Because virtiofs need DMA-able address, so\\nvirtio_fs_enqueue_req() uses kmalloc() to allocate a bounce buffer for\\nall fuse args, copies these args into the bounce buffer and passed the\\nphysical address of the bounce buffer to virtiofsd. The total length of\\nthese fuse args for the passed fuse request is about 10MB, so\\ncopy_args_to_argbuf() invokes kmalloc() with a 10MB size parameter and\\nit triggers the warning in __alloc_pages():\\n\\n\\tif (WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp))\\n\\t\\treturn NULL;\\n\\n5) virtio_fs_enqueue_req() will retry the memory allocation in a\\nkworker, but it won't help, because kmalloc() will always return NULL\\ndue to the abnormal size and finit_module() will hang forever.\\n\\nA feasible solution is to limit the value of max_read for virtio-fs, so\\nthe length passed to kmalloc() will be limited. However it will affect\\nthe maximal read size for normal read. And for virtio-fs write initiated\\nfrom kernel, it has the similar problem but now there is no way to limit\\nfc->max_write in kernel.\\n\\nSo instead of limiting both the values of max_read and max_write in\\nkernel, introducing use_pages_for_kvec_io in fuse_conn and setting it as\\ntrue in virtiofs. When use_pages_for_kvec_io is enabled, fuse will use\\npages instead of pointer to pass the KVEC_IO data.\\n\\nAfter switching to pages for KVEC_IO data, these pages will be used for\\nDMA through virtio-fs. If these pages are backed by vmalloc(),\\n{flush|invalidate}_kernel_vmap_range() are necessary to flush or\\ninvalidate the cache before the DMA operation. So add two new fields in\\nfuse_args_pages to record the base address of vmalloc area and the\\ncondition indicating whether invalidation is needed. Perform the flush\\nin fuse_get_user_pages() for write operations and the invalidation in\\nfuse_release_user_pages() for read operations.\\n\\nIt may seem necessary to introduce another fie\\n---truncated---\"}],\"metrics\":{},\"references\":[{\"url\":\"https://git.kernel.org/stable/c/2bc07714dc955a91d2923a440ea02c3cb3376b10\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/41748675c0bf252b3c5f600a95830f0936d366c1\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/9a8fde56d4b6d51930936ed50f6370a9097328d1\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"}]}}",
   },
}


Log in or create an account to share your comment.

Security Advisory comment format.

This schema specifies the format of a comment related to a security advisory.

UUIDv4 of the comment
UUIDv4 of the Vulnerability-Lookup instance
When the comment was created originally
When the comment was last updated
Title of the comment
Description of the comment
The identifier of the vulnerability (CVE ID, GHSA-ID, PYSEC ID, etc.).



Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
  • Confirmed: The vulnerability is confirmed from an analyst perspective.
  • Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
  • Patched: This vulnerability was successfully patched by the user reporting the sighting.
  • Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
  • Not confirmed: The user expresses doubt about the veracity of the vulnerability.
  • Not patched: This vulnerability was not successfully patched by the user reporting the sighting.