CVE-2023-53854 (GCVE-0-2023-53854)

Vulnerability from cvelistv5 – Published: 2025-12-09 01:30 – Updated: 2025-12-09 01:30
VLAI?
Title
ASoC: mediatek: mt8186: Fix use-after-free in driver remove path
Summary
In the Linux kernel, the following vulnerability has been resolved: ASoC: mediatek: mt8186: Fix use-after-free in driver remove path When devm runs function in the "remove" path for a device it runs them in the reverse order. That means that if you have parts of your driver that aren't using devm or are using "roll your own" devm w/ devm_add_action_or_reset() you need to keep that in mind. The mt8186 audio driver didn't quite get this right. Specifically, in mt8186_init_clock() it called mt8186_audsys_clk_register() and then went on to call a bunch of other devm function. The caller of mt8186_init_clock() used devm_add_action_or_reset() to call mt8186_deinit_clock() but, because of the intervening devm functions, the order was wrong. Specifically at probe time, the order was: 1. mt8186_audsys_clk_register() 2. afe_priv->clk = devm_kcalloc(...) 3. afe_priv->clk[i] = devm_clk_get(...) At remove time, the order (which should have been 3, 2, 1) was: 1. mt8186_audsys_clk_unregister() 3. Free all of afe_priv->clk[i] 2. Free afe_priv->clk The above seemed to be causing a use-after-free. Luckily, it's easy to fix this by simply using devm more correctly. Let's move the devm_add_action_or_reset() to the right place. In addition to fixing the use-after-free, code inspection shows that this fixes a leak (missing call to mt8186_audsys_clk_unregister()) that would have happened if any of the syscon_regmap_lookup_by_phandle() calls in mt8186_init_clock() had failed.
Severity ?
No CVSS data available.
Assigner
References
Impacted products
Vendor Product Version
Linux Linux Affected: 55b423d5623ccd6785429431c2cf5f3e073b73ba , < 3e56a1c04882852e3e7d6c59756a16211ebbc457 (git)
Affected: 55b423d5623ccd6785429431c2cf5f3e073b73ba , < dffd9e2b57cb845930fa885aa634a847ba2130dd (git)
Affected: 55b423d5623ccd6785429431c2cf5f3e073b73ba , < a93d2afd3f77a7331271a0f25c6a11003db69b3c (git)
Create a notification for this product.
    Linux Linux Affected: 6.0
Unaffected: 0 , < 6.0 (semver)
Unaffected: 6.1.30 , ≤ 6.1.* (semver)
Unaffected: 6.3.4 , ≤ 6.3.* (semver)
Unaffected: 6.4 , ≤ * (original_commit_for_fix)
Create a notification for this product.
Show details on NVD website
To clipboard 

{
  "containers": {
    "cna": {
      "affected": [
        {
          "defaultStatus": "unaffected",
          "product": "Linux",
          "programFiles": [
            "sound/soc/mediatek/mt8186/mt8186-afe-clk.c",
            "sound/soc/mediatek/mt8186/mt8186-afe-clk.h",
            "sound/soc/mediatek/mt8186/mt8186-afe-pcm.c",
            "sound/soc/mediatek/mt8186/mt8186-audsys-clk.c",
            "sound/soc/mediatek/mt8186/mt8186-audsys-clk.h"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "lessThan": "3e56a1c04882852e3e7d6c59756a16211ebbc457",
              "status": "affected",
              "version": "55b423d5623ccd6785429431c2cf5f3e073b73ba",
              "versionType": "git"
            },
            {
              "lessThan": "dffd9e2b57cb845930fa885aa634a847ba2130dd",
              "status": "affected",
              "version": "55b423d5623ccd6785429431c2cf5f3e073b73ba",
              "versionType": "git"
            },
            {
              "lessThan": "a93d2afd3f77a7331271a0f25c6a11003db69b3c",
              "status": "affected",
              "version": "55b423d5623ccd6785429431c2cf5f3e073b73ba",
              "versionType": "git"
            }
          ]
        },
        {
          "defaultStatus": "affected",
          "product": "Linux",
          "programFiles": [
            "sound/soc/mediatek/mt8186/mt8186-afe-clk.c",
            "sound/soc/mediatek/mt8186/mt8186-afe-clk.h",
            "sound/soc/mediatek/mt8186/mt8186-afe-pcm.c",
            "sound/soc/mediatek/mt8186/mt8186-audsys-clk.c",
            "sound/soc/mediatek/mt8186/mt8186-audsys-clk.h"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "status": "affected",
              "version": "6.0"
            },
            {
              "lessThan": "6.0",
              "status": "unaffected",
              "version": "0",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "6.1.*",
              "status": "unaffected",
              "version": "6.1.30",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "6.3.*",
              "status": "unaffected",
              "version": "6.3.4",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "*",
              "status": "unaffected",
              "version": "6.4",
              "versionType": "original_commit_for_fix"
            }
          ]
        }
      ],
      "cpeApplicability": [
        {
          "nodes": [
            {
              "cpeMatch": [
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.1.30",
                  "versionStartIncluding": "6.0",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.3.4",
                  "versionStartIncluding": "6.0",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.4",
                  "versionStartIncluding": "6.0",
                  "vulnerable": true
                }
              ],
              "negate": false,
              "operator": "OR"
            }
          ]
        }
      ],
      "descriptions": [
        {
          "lang": "en",
          "value": "In the Linux kernel, the following vulnerability has been resolved:\n\nASoC: mediatek: mt8186: Fix use-after-free in driver remove path\n\nWhen devm runs function in the \"remove\" path for a device it runs them\nin the reverse order. That means that if you have parts of your driver\nthat aren\u0027t using devm or are using \"roll your own\" devm w/\ndevm_add_action_or_reset() you need to keep that in mind.\n\nThe mt8186 audio driver didn\u0027t quite get this right. Specifically, in\nmt8186_init_clock() it called mt8186_audsys_clk_register() and then\nwent on to call a bunch of other devm function. The caller of\nmt8186_init_clock() used devm_add_action_or_reset() to call\nmt8186_deinit_clock() but, because of the intervening devm functions,\nthe order was wrong.\n\nSpecifically at probe time, the order was:\n1. mt8186_audsys_clk_register()\n2. afe_priv-\u003eclk = devm_kcalloc(...)\n3. afe_priv-\u003eclk[i] = devm_clk_get(...)\n\nAt remove time, the order (which should have been 3, 2, 1) was:\n1. mt8186_audsys_clk_unregister()\n3. Free all of afe_priv-\u003eclk[i]\n2. Free afe_priv-\u003eclk\n\nThe above seemed to be causing a use-after-free. Luckily, it\u0027s easy to\nfix this by simply using devm more correctly. Let\u0027s move the\ndevm_add_action_or_reset() to the right place. In addition to fixing\nthe use-after-free, code inspection shows that this fixes a leak\n(missing call to mt8186_audsys_clk_unregister()) that would have\nhappened if any of the syscon_regmap_lookup_by_phandle() calls in\nmt8186_init_clock() had failed."
        }
      ],
      "providerMetadata": {
        "dateUpdated": "2025-12-09T01:30:19.746Z",
        "orgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
        "shortName": "Linux"
      },
      "references": [
        {
          "url": "https://git.kernel.org/stable/c/3e56a1c04882852e3e7d6c59756a16211ebbc457"
        },
        {
          "url": "https://git.kernel.org/stable/c/dffd9e2b57cb845930fa885aa634a847ba2130dd"
        },
        {
          "url": "https://git.kernel.org/stable/c/a93d2afd3f77a7331271a0f25c6a11003db69b3c"
        }
      ],
      "title": "ASoC: mediatek: mt8186: Fix use-after-free in driver remove path",
      "x_generator": {
        "engine": "bippy-1.2.0"
      }
    }
  },
  "cveMetadata": {
    "assignerOrgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
    "assignerShortName": "Linux",
    "cveId": "CVE-2023-53854",
    "datePublished": "2025-12-09T01:30:19.746Z",
    "dateReserved": "2025-12-09T01:27:17.828Z",
    "dateUpdated": "2025-12-09T01:30:19.746Z",
    "state": "PUBLISHED"
  },
  "dataType": "CVE_RECORD",
  "dataVersion": "5.2",
  "vulnerability-lookup:meta": {
    "nvd": "{\"cve\":{\"id\":\"CVE-2023-53854\",\"sourceIdentifier\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\",\"published\":\"2025-12-09T16:17:26.060\",\"lastModified\":\"2025-12-09T18:37:13.640\",\"vulnStatus\":\"Awaiting Analysis\",\"cveTags\":[],\"descriptions\":[{\"lang\":\"en\",\"value\":\"In the Linux kernel, the following vulnerability has been resolved:\\n\\nASoC: mediatek: mt8186: Fix use-after-free in driver remove path\\n\\nWhen devm runs function in the \\\"remove\\\" path for a device it runs them\\nin the reverse order. That means that if you have parts of your driver\\nthat aren\u0027t using devm or are using \\\"roll your own\\\" devm w/\\ndevm_add_action_or_reset() you need to keep that in mind.\\n\\nThe mt8186 audio driver didn\u0027t quite get this right. Specifically, in\\nmt8186_init_clock() it called mt8186_audsys_clk_register() and then\\nwent on to call a bunch of other devm function. The caller of\\nmt8186_init_clock() used devm_add_action_or_reset() to call\\nmt8186_deinit_clock() but, because of the intervening devm functions,\\nthe order was wrong.\\n\\nSpecifically at probe time, the order was:\\n1. mt8186_audsys_clk_register()\\n2. afe_priv-\u003eclk = devm_kcalloc(...)\\n3. afe_priv-\u003eclk[i] = devm_clk_get(...)\\n\\nAt remove time, the order (which should have been 3, 2, 1) was:\\n1. mt8186_audsys_clk_unregister()\\n3. Free all of afe_priv-\u003eclk[i]\\n2. Free afe_priv-\u003eclk\\n\\nThe above seemed to be causing a use-after-free. Luckily, it\u0027s easy to\\nfix this by simply using devm more correctly. Let\u0027s move the\\ndevm_add_action_or_reset() to the right place. In addition to fixing\\nthe use-after-free, code inspection shows that this fixes a leak\\n(missing call to mt8186_audsys_clk_unregister()) that would have\\nhappened if any of the syscon_regmap_lookup_by_phandle() calls in\\nmt8186_init_clock() had failed.\"}],\"metrics\":{},\"references\":[{\"url\":\"https://git.kernel.org/stable/c/3e56a1c04882852e3e7d6c59756a16211ebbc457\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/a93d2afd3f77a7331271a0f25c6a11003db69b3c\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/dffd9e2b57cb845930fa885aa634a847ba2130dd\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"}]}}"
  }
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.



Detection rules are retrieved from Rulezet.